Bug 123549

Summary: Repro scrolling crash with scrollbars that use setPresentationValue on the scrolling thread
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, ggaren, jamesr, luiz, simon.fraser, thorton, tonikitoo
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Pacth beidson: review+

Beth Dakin
Reported 2013-10-30 19:28:09 PDT
We're crashing in ScrollingTreeScrollingNodeMac::setScrollLayerPosition() with what appears to be a bad ScrollbarPainter. <rdar://problem/15246606>
Attachments
Patch (1.59 KB, patch)
2013-10-30 19:32 PDT, Beth Dakin 		darin: review+
DetailsFormatted DiffDiff
Pacth (3.46 KB, patch)
2013-10-31 13:56 PDT, Beth Dakin 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2013-10-30 19:32:29 PDT
Created attachment 215600 [details] Patch Here's a speculative fix. Unfortunately I have not been able to repro this in my own build, but it is probably timing-dependent, so that might make sense.
Simon Fraser (smfr)
Comment 2 2013-10-31 10:19:04 PDT
Beth, I think it would be good to get someone who sees the crash (e.g. Tim) to test this patch. He said it was really easy to hit.
Beth Dakin
Comment 3 2013-10-31 11:03:17 PDT
(In reply to comment #2) > Beth, I think it would be good to get someone who sees the crash (e.g. Tim) to test this patch. He said it was really easy to hit. I can repro the crash easily too! But not in a debug or release build.
Beth Dakin
Comment 4 2013-10-31 11:24:49 PDT
Committed change with http://trac.webkit.org/changeset/158375
Beth Dakin
Comment 5 2013-10-31 13:52:27 PDT
This bug still reproduces. Attempting another speculative fix.
Beth Dakin
Comment 6 2013-10-31 13:56:00 PDT
Created attachment 215674 [details] Pacth Here's another speculative fix.
Beth Dakin
Comment 7 2013-10-31 14:02:45 PDT
http://trac.webkit.org/changeset/158391
Note You need to log in before you can comment on or make changes to this bug.