Bug 123544

Summary: [Gtk] Build is failing after r158317
Product: WebKit Reporter: Brendan Long <b.long>
Component: New BugsAssignee: Brendan Long <b.long>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Fix 'Oops' line
none
Patch
none
Patch
none
Just the JSCryptoKey fix none

Brendan Long
Reported 2013-10-30 17:04:56 PDT
[Gtk] Missing forwarding headers after r158317
Attachments
Patch (3.58 KB, patch)
2013-10-30 17:05 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
Patch (4.91 KB, patch)
2013-10-30 19:48 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
Fix 'Oops' line (4.93 KB, patch)
2013-10-30 20:35 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
Patch (2.19 KB, patch)
2013-10-30 21:12 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
Patch (2.14 KB, patch)
2013-10-30 22:29 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
Just the JSCryptoKey fix (1.31 KB, patch)
2013-10-30 22:40 PDT, Brendan Long 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Brendan Long
Comment 1 2013-10-30 17:05:40 PDT
Created attachment 215580 [details] Patch
Brendan Long
Comment 2 2013-10-30 17:06:53 PDT
I was getting errors like: CXX Source/WebCore/bindings/js/libWebCore_la-JSDOMPromise.lo In file included from ../../Source/WebCore/bindings/js/JSDOMPromise.cpp:27:0: ../../Source/WebCore/bindings/js/JSDOMPromise.h:32:38: fatal error: JavaScriptCore/JSPromise.h: No such file or directory #include <JavaScriptCore/JSPromise.h> ^ compilation terminated. This seems to be caused by r158317, and this patch fixes it for me.
Brendan Long
Comment 3 2013-10-30 19:29:43 PDT
Hm, I don't know what the JSCryptoKey error is about. I saw it on my machine earlier, but I don't get it anymore.
Brendan Long
Comment 4 2013-10-30 19:48:39 PDT
Created attachment 215601 [details] Patch Ok, this fixes the JScryptoKey error too. I fixed it and then forgot about it, since the file stayed built.
WebKit Commit Bot
Comment 5 2013-10-30 20:33:32 PDT
Comment on attachment 215601 [details] Patch Rejecting attachment 215601 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 215601, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/17088423
Brendan Long
Comment 6 2013-10-30 20:35:38 PDT
Created attachment 215605 [details] Fix 'Oops' line
Alexey Proskuryakov
Comment 7 2013-10-30 20:55:53 PDT
Comment on attachment 215605 [details] Fix 'Oops' line This is not the right fix, non-API forwarding headers should be in WebCore/ForwardingHeaders.
Alexey Proskuryakov
Comment 8 2013-10-30 20:59:26 PDT
Comment on attachment 215605 [details] Fix 'Oops' line View in context: https://bugs.webkit.org/attachment.cgi?id=215605&action=review Sorry for breaking the build - EWS didn't tell me, because the build was already broken then. > Source/WebCore/GNUmakefile.list.am:153 > + DerivedSources/WebCore/JSCryptoKey.cpp \ It's OK to add the .cpp file, but not necessary - it's all ifdefed out.
Alexey Proskuryakov
Comment 9 2013-10-30 21:01:11 PDT
Also, this part of my patch is wrong: #include <JavaScriptCore/JSGlobalObject.h> #include <JavaScriptCore/JSPromise.h> #include <JavaScriptCore/JSPromiseResolver.h> #include <JavaScriptCore/StrongInlines.h> These should be included as <runtime/JSGlobalObject.h> and so on.
Brendan Long
Comment 10 2013-10-30 21:12:49 PDT
Created attachment 215609 [details] Patch How about this? I had previously assumed that the #include lines were correct.
Build Bot
Comment 11 2013-10-30 21:41:18 PDT
Comment on attachment 215609 [details] Patch Attachment 215609 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17108408
Brendan Long
Comment 12 2013-10-30 21:46:23 PDT
From the mac build: > In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/bindings/js/JSDOMPromise.cpp:27: > /Volumes/Data/EWS/WebKit/Source/WebCore/bindings/js/JSDOMPromise.h:31:10: fatal error: 'JavaScriptCore/heap/StrongInlines.h' file not found > #include <JavaScriptCore/heap/StrongInlines.h> What? :\
Build Bot
Comment 13 2013-10-30 21:51:53 PDT
Comment on attachment 215609 [details] Patch Attachment 215609 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17788112
Build Bot
Comment 14 2013-10-30 21:52:48 PDT
Comment on attachment 215609 [details] Patch Attachment 215609 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/17038414
Alexey Proskuryakov
Comment 15 2013-10-30 22:14:22 PDT
> > #include <JavaScriptCore/heap/StrongInlines.h> > > What? :\ Should be just <heap/StrongInlines.h>
Brendan Long
Comment 16 2013-10-30 22:29:14 PDT
Created attachment 215615 [details] Patch Oh, I see. Sorry, wasn't reading closely enough I guess. This version fixes that, but may still fail due to lack of forwarding headers. We'll see what happens.
Alexey Proskuryakov
Comment 17 2013-10-30 22:35:58 PDT
Fixed the style of includes in <http://trac.webkit.org/r158345>. Still needs adding JSCryptoKey.h.
Brendan Long
Comment 18 2013-10-30 22:40:36 PDT
Created attachment 215617 [details] Just the JSCryptoKey fix
WebKit Commit Bot
Comment 19 2013-10-30 23:23:28 PDT
Comment on attachment 215617 [details] Just the JSCryptoKey fix Clearing flags on attachment: 215617 Committed r158347: <http://trac.webkit.org/changeset/158347>
WebKit Commit Bot
Comment 20 2013-10-30 23:23:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.