Bug 123534 – Web Inspector: Remove basic uses of InspectorState from agents

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

All InspectorAgents are given an InspectorState object, but we don't use the restore functionality. So we should remove the added complexity.

However, many of the agent's store legitimate state on m_state. Convert all plain data type / String InspectorState uses to member variables.

Next step will be handling the few remaining InspectorObjects.

[Radar WebKit Bug Importer]

<rdar://problem/15356682>

[Joseph Pecoraro]

Created attachment 215569 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 215569 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=215569&action=review

> Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:70
>  namespace DOMDebuggerAgentState {
>  static const char eventListenerBreakpoints[] = "eventListenerBreakpoints";
> -static const char pauseOnAllXHRs[] = "pauseOnAllXHRs";
>  static const char xhrBreakpoints[] = "xhrBreakpoints";
>  }

Why can't the rest be removed?

[WebKit Commit Bot]

Comment on attachment 215569 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 215569

Committed r158331: <http://trac.webkit.org/changeset/158331>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.