| Summary: | Web Inspector: Add Support for OS X Full Screen Mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos <perezcarlos> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Enhancement | CC: | joepeck, timothy, tobi+webkit, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Carlos
2013-10-30 06:42:25 PDT
*** Bug 128529 has been marked as a duplicate of this bug. *** Created attachment 255606 [details]
[PATCH] Proposed Fix
Comment on attachment 255606 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=255606&action=review > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:317 > + [window setCollectionBehavior:([window collectionBehavior] | NSWindowCollectionBehaviorFullScreenPrimary)]; Why Primary here and NSWindowCollectionBehaviorFullScreenAllowsTiling above? Comment on attachment 255606 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=255606&action=review >> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:317 >> + [window setCollectionBehavior:([window collectionBehavior] | NSWindowCollectionBehaviorFullScreenPrimary)]; > > Why Primary here and NSWindowCollectionBehaviorFullScreenAllowsTiling above? This adds Primary, and then ~5 lines later it adds NSWindowCollectionBehaviorFullScreenAllowsTiling. Both WK1 and WK2 are adding both collection behaviors. |