Bug 123476

Summary: Add bindings code for crypto algorithm dictionaries
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: BindingsAssignee: Alexey Proskuryakov <ap>
Severity: Normal CC: buildbot, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122679    
Description Flags
proposed patch sam: review+, buildbot: commit-queue-

Description Alexey Proskuryakov 2013-10-29 15:49:50 PDT
We need to convert Algorithm dictionaries to C++ structs/classes, so that we could pass them to DOM code.

This is somewhat complicated due to incompatibilities between Web IDL and WebCrypto (e.g. WebCrypto uses nested dictionaries, which is not allowed, and it also doesn't describe what exactly to do with missing dictionary elements).
Comment 1 Alexey Proskuryakov 2013-10-29 16:07:53 PDT
Created attachment 215440 [details]
proposed patch

Will fail to compile, because it depends on other patches. But the code is all disabled anyway, so EWS is not of much use.
Comment 2 Build Bot 2013-10-29 16:10:50 PDT
Comment on attachment 215440 [details]
proposed patch

Attachment 215440 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/17148147
Comment 3 Alexey Proskuryakov 2013-10-31 10:31:31 PDT
Committed <http://trac.webkit.org/r158366>.
Comment 4 Alexey Proskuryakov 2013-10-31 10:38:26 PDT
Follow-up in <http://trac.webkit.org/r158367>.