Bug 123459

Summary: Make SimpleLineLayout::Layout a variable size object
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 123505    
Bug Blocks:    
Attachments:
Description Flags
patch
none
better patch kling: review+, buildbot: commit-queue-

Antti Koivisto
Reported 2013-10-29 12:46:56 PDT
less memory
Attachments
patch (7.64 KB, patch)
2013-10-29 12:51 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
better patch (7.68 KB, patch)
2013-10-29 12:58 PDT, Antti Koivisto 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-10-29 12:51:53 PDT
Created attachment 215411 [details] patch
Antti Koivisto
Comment 2 2013-10-29 12:58:39 PDT
Created attachment 215412 [details] better patch
Andreas Kling
Comment 3 2013-10-29 13:00:16 PDT
Comment on attachment 215412 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=215412&action=review Very cool. r=me > Source/WebCore/rendering/SimpleLineLayout.cpp:61 > -#endif > +#endif why > Source/WebCore/rendering/SimpleLineLayout.h:62 > + Run runs[0]; You may need some #pragma tomfoolery to placate MSVC. See ElementData.h
Build Bot
Comment 4 2013-10-29 13:40:57 PDT
Comment on attachment 215412 [details] better patch Attachment 215412 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/16938053
Antti Koivisto
Comment 5 2013-10-29 13:48:39 PDT
https://trac.webkit.org/r158214
Csaba Osztrogonác
Comment 6 2013-10-30 03:23:40 PDT
(In reply to comment #5) > https://trac.webkit.org/r158214 It made almost all tests crash on GTK and EFL, see https://bugs.webkit.org/show_bug.cgi?id=123505 for details.
Note You need to log in before you can comment on or make changes to this bug.