Summary: | Make SimpleLineLayout::Layout a variable size object | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 123505 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Antti Koivisto
2013-10-29 12:46:56 PDT
Created attachment 215411 [details]
patch
Created attachment 215412 [details]
better patch
Comment on attachment 215412 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=215412&action=review Very cool. r=me > Source/WebCore/rendering/SimpleLineLayout.cpp:61 > -#endif > +#endif why > Source/WebCore/rendering/SimpleLineLayout.h:62 > + Run runs[0]; You may need some #pragma tomfoolery to placate MSVC. See ElementData.h Comment on attachment 215412 [details] better patch Attachment 215412 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/16938053 (In reply to comment #5) > https://trac.webkit.org/r158214 It made almost all tests crash on GTK and EFL, see https://bugs.webkit.org/show_bug.cgi?id=123505 for details. |