Summary: | Add myself as a comitter. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nadav Rotem <nrotem> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, glenn | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Nadav Rotem
2013-10-29 11:44:01 PDT
Created attachment 215408 [details]
Patch
Comment on attachment 215408 [details] Patch Rejecting attachment 215408 [details] from commit-queue. nrotem@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. I can't add myself to contributors.json because only people who's name is in contributors.json can commit. (In reply to comment #3) > I can't add myself to contributors.json because only people who's name is in contributors.json can commit. The usual way to do it is to 'svn commit' the old fashioned way! Your bugzilla credentials are your svn credentials. (In reply to comment #4) > (In reply to comment #3) > > I can't add myself to contributors.json because only people who's name is in contributors.json can commit. > > The usual way to do it is to 'svn commit' the old fashioned way! > > Your bugzilla credentials are your svn credentials. (And you should have svn commit privileges - that's separate from contributors.json privileges.) Committed in 158222. |