RESOLVED FIXED 123455
Add myself as a comitter. 
https://bugs.webkit.org/show_bug.cgi?id=123455
Summary Add myself as a comitter.
Nadav Rotem
Reported 2013-10-29 11:44:01 PDT
Add myself as a comitter.
Attachments
Patch (1.20 KB, patch)
2013-10-29 11:44 PDT, Nadav Rotem 		andersca: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nadav Rotem
Comment 1 2013-10-29 11:44:30 PDT
Created attachment 215408 [details] Patch
WebKit Commit Bot
Comment 2 2013-10-29 13:12:20 PDT
Comment on attachment 215408 [details] Patch Rejecting attachment 215408 [details] from commit-queue. nrotem@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Nadav Rotem
Comment 3 2013-10-29 13:14:55 PDT
I can't add myself to contributors.json because only people who's name is in contributors.json can commit.
Filip Pizlo
Comment 4 2013-10-29 13:16:40 PDT
(In reply to comment #3) > I can't add myself to contributors.json because only people who's name is in contributors.json can commit. The usual way to do it is to 'svn commit' the old fashioned way! Your bugzilla credentials are your svn credentials.
Filip Pizlo
Comment 5 2013-10-29 13:17:28 PDT
(In reply to comment #4) > (In reply to comment #3) > > I can't add myself to contributors.json because only people who's name is in contributors.json can commit. > > The usual way to do it is to 'svn commit' the old fashioned way! > > Your bugzilla credentials are your svn credentials. (And you should have svn commit privileges - that's separate from contributors.json privileges.)
Nadav Rotem
Comment 6 2013-10-29 14:03:46 PDT
Committed in 158222.
Note You need to log in before you can comment on or make changes to this bug.