| Summary: | Multiple runs per line on simple line path | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2013-10-29 08:11:28 PDT
Created attachment 215389 [details]
patch
Attachment 215389 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayout.h', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h']" exit_code: 1
Source/WebCore/rendering/SimpleLineLayoutResolver.h:98: Missing spaces around && [whitespace/operators] [3]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 215389 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=215389&action=review r=me. > Source/WebCore/rendering/SimpleLineLayout.cpp:263 > + Vector<Run, 4> lineRuns; > + lineRuns.append(Run(lineStartOffset, 0)); This can be an uncheckedAppend() since we know there is space in the inline capacity here. > Source/WebCore/rendering/SimpleLineLayoutResolver.h:45 > + Run(const Iterator&); explicit >> Source/WebCore/rendering/SimpleLineLayoutResolver.h:98 >> + Iterator(RunResolver::Iterator&&); > > Missing spaces around && [whitespace/operators] [3] explicit > Source/WebCore/rendering/SimpleLineLayoutResolver.h:244 > + rect.unite((*it).rect()); No need to declare "rect" before this line. LayoutRect rect = (*it).rect(); |