Bug 123436

Summary: [Mac] Rationalize user defaults override code
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
mitz: review+
patch for landing none

Alexey Proskuryakov
Reported 2013-10-29 00:31:05 PDT
DumpRenderTree and WebKitTestRunner use a variety of techniques to change user defaults, from registering a default to setting application preferences to overriding via argument domain. There is no reason for this variety as far as I can tell.
Attachments
proposed patch (13.31 KB, patch)
2013-10-29 00:40 PDT, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
patch for landing (13.31 KB, patch)
2013-10-29 10:16 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-10-29 00:40:32 PDT
Created attachment 215368 [details] proposed patch Let's see if EWS agrees that this doesn't change behavior...
mitz
Comment 2 2013-10-29 07:19:18 PDT
Comment on attachment 215368 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=215368&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:694 > + @"AppleLanguages": @[@"en"], Spaces around @"en", please.
Alexey Proskuryakov
Comment 3 2013-10-29 10:16:05 PDT
Created attachment 215394 [details] patch for landing
WebKit Commit Bot
Comment 4 2013-10-29 10:46:01 PDT
Comment on attachment 215394 [details] patch for landing Clearing flags on attachment: 215394 Committed r158199: <http://trac.webkit.org/changeset/158199>
WebKit Commit Bot
Comment 5 2013-10-29 10:46:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.