Bug 123426

Summary: Web Inspector: Remove old Inspector.json version files and generators
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: buildbot, commit-queue, graouts, gyuyoung.kim, joepeck, rakuco, rniwa, timothy, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed Fix
joepeck: review-, joepeck: commit-queue-
[PATCH] Proposed Fix
timothy: review-, buildbot: commit-queue-
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2013-10-28 16:26:58 PDT
We do not have a use for Inspector-0.1.js and Inspector-1.0.js. They do not correspond to any known releases and use outdated syntax.
Comment 1 Radar WebKit Bug Importer 2013-10-28 16:27:21 PDT
Comment 2 Joseph Pecoraro 2013-10-28 16:27:36 PDT
Created attachment 215342 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2013-10-28 16:36:27 PDT
Comment on attachment 215342 [details]
[PATCH] Proposed Fix

Missed removing from Xcode project and something else.
Comment 4 Joseph Pecoraro 2013-10-28 16:38:23 PDT
Created attachment 215343 [details]
[PATCH] Proposed Fix
Comment 5 Build Bot 2013-10-28 17:07:54 PDT
Comment on attachment 215343 [details]
[PATCH] Proposed Fix

Attachment 215343 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/16018034
Comment 6 Build Bot 2013-10-28 17:17:56 PDT
Comment on attachment 215343 [details]
[PATCH] Proposed Fix

Attachment 215343 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/16258040
Comment 7 Build Bot 2013-10-28 17:21:06 PDT
Comment on attachment 215343 [details]
[PATCH] Proposed Fix

Attachment 215343 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/16158036
Comment 8 Timothy Hatcher 2013-10-28 21:42:23 PDT
generate-inspector-protocol-version uses the files to detect compatibility errors. We should just remove generate-inspector-protocol-version. We do a good job at compatibility without it.
Comment 9 Joseph Pecoraro 2013-10-29 10:21:55 PDT
Created attachment 215395 [details]
[PATCH] Proposed Fix
Comment 10 WebKit Commit Bot 2013-10-29 11:36:33 PDT
Comment on attachment 215395 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 215395

Committed r158203: <http://trac.webkit.org/changeset/158203>
Comment 11 WebKit Commit Bot 2013-10-29 11:36:36 PDT
All reviewed patches have been landed.  Closing bug.