Bug 123372

Summary: Refactor parser rollback logic
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review+

Oliver Hunt
Reported 2013-10-25 16:23:59 PDT
Refactor parser rollback logic
Attachments
Patch (5.88 KB, patch)
2013-10-25 16:24 PDT, Oliver Hunt 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-10-25 16:24:50 PDT
Created attachment 215229 [details] Patch
Oliver Hunt
Comment 2 2013-10-25 17:23:39 PDT
Committed r158074: <http://trac.webkit.org/changeset/158074>
Geoffrey Garen
Comment 3 2013-10-25 17:56:33 PDT
Comment on attachment 215229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215229&action=review > Source/JavaScriptCore/parser/Parser.cpp:202 > + auto savePoint = createSavePoint(); In cases like this, I think the code is more self-documenting, and not harder to write, if it says "SavePoint savePoint = ...".
Filip Pizlo
Comment 4 2013-10-25 18:19:07 PDT
Comment on attachment 215229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215229&action=review R=me too fwiw. >> Source/JavaScriptCore/parser/Parser.cpp:202 >> + auto savePoint = createSavePoint(); > > In cases like this, I think the code is more self-documenting, and not harder to write, if it says "SavePoint savePoint = ...". +1 This is one of those situations where types are cool.
Note You need to log in before you can comment on or make changes to this bug.