| Summary: | Web Inspector: Implement TimelineRecording and per-callsite timelines | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | graouts, joepeck, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2013-10-25 15:44:24 PDT
Created attachment 215224 [details]
Patch
Comment on attachment 215224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215224&action=review r=me > Source/WebInspectorUI/UserInterface/TimelineRecording.js:32 > + this._timelines = {script: new WebInspector.Timeline, layout: new WebInspector.Timeline}; > + this._sourceCodeTimelinesMap = new Map; > + this._eventMarkers = []; When are these cleared? > Source/WebInspectorUI/UserInterface/TimelineRecording.js:41 > + get timelines() { Style: { on its own line Comment on attachment 215224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215224&action=review >> Source/WebInspectorUI/UserInterface/TimelineRecording.js:32 >> + this._eventMarkers = []; > > When are these cleared? They are cleared when the recordings are cleared, on reload. |