Bug 123367 - Web Inspector: Implement TimelineRecording and per-callsite timelines
Summary: Web Inspector: Implement TimelineRecording and per-callsite timelines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-25 15:44 PDT by Timothy Hatcher
Modified: 2014-01-20 19:00 PST (History)
4 users (show)

See Also:

Attachments
Patch (10.31 KB, patch)
2013-10-25 15:47 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-10-25 15:44:24 PDT 
Add the implementation for TimelineRecording and helpers.
Comment 1 Radar WebKit Bug Importer 2013-10-25 15:44:31 PDT 
<rdar://problem/15324242>
Comment 2 Timothy Hatcher 2013-10-25 15:47:20 PDT 
Created attachment 215224 [details]
Patch
Comment 3 Joseph Pecoraro 2013-10-28 10:44:59 PDT 
Comment on attachment 215224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215224&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:32
> +    this._timelines = {script: new WebInspector.Timeline, layout: new WebInspector.Timeline};
> +    this._sourceCodeTimelinesMap = new Map;
> +    this._eventMarkers = [];

When are these cleared?

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:41
> +    get timelines() {

Style: { on its own line
Comment 4 Timothy Hatcher 2013-10-28 11:18:57 PDT 
Comment on attachment 215224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215224&action=review

>> Source/WebInspectorUI/UserInterface/TimelineRecording.js:32
>> +    this._eventMarkers = [];
> 
> When are these cleared?

They are cleared when the recordings are cleared, on reload.
Comment 5 Timothy Hatcher 2014-01-20 19:00:38 PST 
https://trac.webkit.org/changeset/162401