WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123367
Web Inspector: Implement TimelineRecording and per-callsite timelines
https://bugs.webkit.org/show_bug.cgi?id=123367
Summary
Web Inspector: Implement TimelineRecording and per-callsite timelines
Timothy Hatcher
Reported
2013-10-25 15:44:24 PDT
Add the implementation for TimelineRecording and helpers.
Attachments
Patch
(10.31 KB, patch)
2013-10-25 15:47 PDT
,
Timothy Hatcher
joepeck
: review+
timothy
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-10-25 15:44:31 PDT
<
rdar://problem/15324242
>
Timothy Hatcher
Comment 2
2013-10-25 15:47:20 PDT
Created
attachment 215224
[details]
Patch
Joseph Pecoraro
Comment 3
2013-10-28 10:44:59 PDT
Comment on
attachment 215224
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=215224&action=review
r=me
> Source/WebInspectorUI/UserInterface/TimelineRecording.js:32 > + this._timelines = {script: new WebInspector.Timeline, layout: new WebInspector.Timeline}; > + this._sourceCodeTimelinesMap = new Map; > + this._eventMarkers = [];
When are these cleared?
> Source/WebInspectorUI/UserInterface/TimelineRecording.js:41 > + get timelines() {
Style: { on its own line
Timothy Hatcher
Comment 4
2013-10-28 11:18:57 PDT
Comment on
attachment 215224
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=215224&action=review
>> Source/WebInspectorUI/UserInterface/TimelineRecording.js:32 >> + this._eventMarkers = []; > > When are these cleared?
They are cleared when the recordings are cleared, on reload.
Timothy Hatcher
Comment 5
2014-01-20 19:00:38 PST
https://trac.webkit.org/changeset/162401
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug