Bug 123364

Summary:

Web Inspector: Single click on links in non-read-only TextEditors should not follow links

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Timothy Hatcher

Reported 2013-10-25 15:11:55 PDT

We should make command-click be required for link following in all non-read-only TextEditors. Note: See SourceCodeTextEditor's tokenTrackingControllerHighlightedRangeWasClicked, TextEditor's _openClickedLinks and CSSStyleDeclarationTextEditor's tokenTrackingControllerHighlightedRangeWasClicked.

Attachments
Patch (5.60 KB, patch) 2019-04-03 13:17 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-10-25 15:12:19 PDT

<rdar://problem/15323913>

Devin Rousso

Comment 2 2019-04-03 13:17:32 PDT

Created attachment 366634 [details] Patch

WebKit Commit Bot

Comment 3 2019-04-03 14:04:03 PDT

Comment on attachment 366634 [details] Patch Clearing flags on attachment: 366634 Committed r243826: <https://trac.webkit.org/changeset/243826>

WebKit Commit Bot

Comment 4 2019-04-03 14:04:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.