| Summary: | Improve JSC Parser error messages | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||||||
| Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, eflews.bot, gyuyoung.kim, rniwa | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Oliver Hunt
2013-10-25 07:54:33 PDT
Created attachment 215175 [details]
Patch
Comment on attachment 215175 [details] Patch Attachment 215175 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/12348042 Comment on attachment 215175 [details] Patch Attachment 215175 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/10898092 Comment on attachment 215175 [details] Patch Attachment 215175 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/12228067 Comment on attachment 215175 [details] Patch Attachment 215175 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/12438006 New failing tests: http/tests/workers/worker-importScripts.html http/tests/workers/shared-worker-importScripts.html fast/regex/dom/non-pattern-characters.html Created attachment 215179 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 215180 [details]
Patch
Comment on attachment 215180 [details] Patch Attachment 215180 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/12458005 Comment on attachment 215180 [details] Patch Attachment 215180 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/12428005 Created attachment 215182 [details]
Patch
Comment on attachment 215182 [details] Patch Attachment 215182 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/10188007 Comment on attachment 215182 [details] Patch Attachment 215182 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/12508005 Comment on attachment 215182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215182&action=review > LayoutTests/fast/regex/dom/non-pattern-characters-expected.txt:36 > +PASS /\/ threw exception SyntaxError: Unexpected token '/'. Invalid regular expression.. "Invalid regular expression" seems to have two periods (..) at the end, unlike other errors. Created attachment 215184 [details]
Appease efl build
Comment on attachment 215184 [details] Appease efl build View in context: https://bugs.webkit.org/attachment.cgi?id=215184&action=review r=me, assuming ews digs it. > Source/JavaScriptCore/parser/Parser.cpp:107 > + , m_lastFunctionName(0) nullptr > Source/JavaScriptCore/parser/Parser.cpp:1045 > + return 0; nullptr > Source/JavaScriptCore/parser/Parser.cpp:1055 > + m_lastFunctionName = 0; nullptr > Source/JavaScriptCore/parser/Parser.cpp:2014 > + ASSERT_NOT_REACHED(); > + return "error"; Why not just RELEASE_ASSERT_NOT_REACHED here? Committed r158014: <http://trac.webkit.org/changeset/158014> |