Bug 123300

Summary: Simplify window occlusion detection code
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebKit2Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix thorton: review+, buildbot: commit-queue-

Gavin Barraclough
Reported 2013-10-24 16:20:17 PDT
Also, add missing viewStateDidChange.
Attachments
Fix (7.61 KB, patch)
2013-10-24 16:30 PDT, Gavin Barraclough 		thorton: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2013-10-24 16:30:23 PDT
Created attachment 215120 [details] Fix
Build Bot
Comment 2 2013-10-24 16:54:46 PDT
Comment on attachment 215120 [details] Fix Attachment 215120 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/10268189
Tim Horton
Comment 3 2013-10-24 16:55:18 PDT
Comment on attachment 215120 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=215120&action=review > Source/WebKit2/ChangeLog:10 > + dectection being dynamically toggled). Simpler to just rely of the actual value s/of/on/
Tim Horton
Comment 4 2013-10-24 16:56:18 PDT
As long as you protect it with a 10.9+ check.
Build Bot
Comment 5 2013-10-24 17:11:55 PDT
Comment on attachment 215120 [details] Fix Attachment 215120 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/10398221
Gavin Barraclough
Comment 6 2013-10-24 17:42:16 PDT
Fixed in r157968
Note You need to log in before you can comment on or make changes to this bug.