Bug 123299

Summary:

The GetById->GetByOffset AI-based optimization should actually do things

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	oliver: review+

Description Filip Pizlo 2013-10-24 16:10:46 PDT

Somehow or another, we ended up turning this optimization off by making GetByIdStatus not set m_state to Simple.  The result was that we'd return a GetByIdStatus advertising that it has NoInformation, and the abstract interpreter would assume that it can't optimize the GetById.

Lol.

Comment 1 Filip Pizlo 2013-10-24 16:12:54 PDT

Created attachment 215118 [details]
the patch

Comment 2 Filip Pizlo 2013-10-28 10:18:36 PDT

Landed in http://trac.webkit.org/changeset/158114