Bug 123288

Summary: Crash in WebCore::NavigationScheduler::startTimer()
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Page LoadingAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ddkilzer, japhet, joepeck
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch and API test ap: review+

Daniel Bates
Reported 2013-10-24 13:23:47 PDT
Currently NavigationScheduler::startTimer() synchronously notifies the client of a scheduled redirect r before notifying the Web Inspector. If a client chooses to cancel r upon receiving this callback then NavigationScheduler::m_redirect will become null and we'll subsequently crash when informing the Web Inspector that r was scheduled. Instead, NavigationScheduler::startTimer() should notify the Web Inspector before it notifies the client of a scheduled redirect.
Attachments
Patch and API test (12.92 KB, patch)
2013-10-24 13:27 PDT, Daniel Bates 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-10-24 13:24:50 PDT
<rdar://problem/14055644>
Daniel Bates
Comment 2 2013-10-24 13:27:35 PDT
Created attachment 215100 [details] Patch and API test
Alexey Proskuryakov
Comment 3 2013-10-24 13:37:09 PDT
Comment on attachment 215100 [details] Patch and API test View in context: https://bugs.webkit.org/attachment.cgi?id=215100&action=review r=me. Please wait for EWS to become green. > Tools/TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html:4 > +<iframe id="frame" src="about: blank"></iframe> Maybe "about:blank" to make it less confusing? > Tools/TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm:34 > +static NSURL* testURL() Star is misplaced.
Daniel Bates
Comment 4 2013-10-24 14:39:19 PDT
Committed r157957: <http://trac.webkit.org/changeset/157957>
Note You need to log in before you can comment on or make changes to this bug.