Bug 123264 – Remove HTMLMediaElement.startTime

• Component: New Bugs
• Status: RESOLVED FIXED

[Xabier Rodríguez Calvar]

Remove HTMLMediaElement.startTime

[Xabier Rodríguez Calvar]

Created attachment 215051 [details]
Patch

Backported from Blink at https://codereview.chromium.org/32583003.

After following the discussions at http://code.google.com/p/chromium/issues/detail?id=309473, I think it also makes sense to have this in WebKit.

I am also planning to backport http://code.google.com/p/chromium/issues/detail?id=309474 too.

[Build Bot]

Comment on attachment 215051 [details]
Patch

Attachment 215051 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/10388040

New failing tests:
media/controls-styling-strict.html
media/video-no-audio.html
media/controls-strict.html
media/audio-controls-rendering.html
media/controls-without-preload.html

[Build Bot]

Created attachment 215054 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 215051 [details]
Patch

Attachment 215051 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/10388047

New failing tests:
media/video-no-audio.html
media/controls-strict.html
media/controls-styling-strict.html
media/audio-controls-rendering.html
media/controls-without-preload.html
media/controls-after-reload.html

[Build Bot]

Created attachment 215056 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 215051 [details]
Patch

Attachment 215051 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/10358058

New failing tests:
media/video-no-audio.html
media/controls-strict.html
media/controls-styling-strict.html
media/audio-controls-rendering.html
media/controls-without-preload.html
media/controls-after-reload.html

[Build Bot]

Created attachment 215061 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Eric Carlson]

Comment on attachment 215051 [details]
Patch

Ah, the failures happen because you didn't update the Mac port's JavaScript based media controller.

[Eric Carlson]

(In reply to comment #8)
> (From update of attachment 215051 [details])
> Ah, the failures happen because you didn't update the Mac port's JavaScript based media controller.

Source/WebCore/Modules/mediacontrols/mediaControlsApple.js

[Xabier Rodríguez Calvar]

Created attachment 215093 [details]
Patch

Removed startTime from the apple controls and some other places.

[Eric Carlson]

Comment on attachment 215093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215093&action=review

r=me, but please revert the changes to HTML_Timed_Media_Elements.html

> Websites/webkit.org/ChangeLog:9
> +        * specs/HTML_Timed_Media_Elements.html: Removed traces of
> +        startTime.

This ancient spec shouldn't be edited.

[Xabier Rodríguez Calvar]

Created attachment 215157 [details]
Patch

Removed startTime from the apple controls and some other places.

[Xabier Rodríguez Calvar]

Comment on attachment 215157 [details]
Patch

GObject DOM symbols update is missing

[Xabier Rodríguez Calvar]

Created attachment 215162 [details]
Patch

Removed the spec update and updated GObject DOM symbols.

[Xabier Rodríguez Calvar]

(In reply to comment #14)
> Created an attachment (id=215162) [details]
> Patch
> 
> Removed the spec update and updated GObject DOM symbols.

Carlos, would you mind checking the GObject DOM symbols as Eric reviwed the rest? Then I will be able the set the cq+

[Carlos Garcia Campos]

(In reply to comment #15)
> (In reply to comment #14)
> > Created an attachment (id=215162) [details] [details]
> > Patch
> > 
> > Removed the spec update and updated GObject DOM symbols.
> 
> Carlos, would you mind checking the GObject DOM symbols as Eric reviwed the rest? Then I will be able the set the cq+

Instead of removing the symbol, you should add a custom implementation in Source/WebCore/bindings/gobject/WebKitDOMCustom

to not break the API/ABI.

[Xabier Rodríguez Calvar]

Created attachment 215262 [details]
Patch

Added custom implementation to not break the API and fixed symbols.

[Carlos Garcia Campos]

Comment on attachment 215262 [details]
Patch

GObject DOM bindings changes look good to me

[Xabier Rodríguez Calvar]

(In reply to comment #17)
> Created an attachment (id=215262) [details]
> Patch
> 
> Added custom implementation to not break the API and fixed symbols.

Eric, could you please r+?

[WebKit Commit Bot]

Comment on attachment 215262 [details]
Patch

Clearing flags on attachment: 215262

Committed r158112: <http://trac.webkit.org/changeset/158112>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.