Bug 123261

Summary: [GTK] Deprecate public dispatch_event method in objects implementing EventTarget interface
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: BindingsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, cdumez, commit-queue, gustavo, jsbell, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2013-10-24 03:20:04 PDT
The interface function should be used instead. add/remove_event_listener methods are not duplicated also because they are skipped by the script generator because they receive an EventListener as argument. We need a special case for dispatch_event that is currently generated twice, a public version using the object type as first parameter and the private one used to implement the interface receiving the interface type as first argument.
Attachments
Patch (63.19 KB, patch)
2013-10-24 03:29 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-10-24 03:29:17 PDT
Created attachment 215049 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-10-24 05:06:39 PDT
Comment on attachment 215049 [details] Patch LGTM
Carlos Garcia Campos
Comment 3 2013-10-26 04:00:27 PDT
Committed r158083: <http://trac.webkit.org/changeset/158083>
Note You need to log in before you can comment on or make changes to this bug.