Bug 123257

Summary: [GTK] Disable css-image-orientation
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKitGTKAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dbates, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2013-10-24 01:12:37 PDT
About 30 tests have been failed since r157909 on GTK port only. I think these regressions happen because GTK port only enables css-image-orientation now. So, I'd like to disable it at the moment. I file a bug(Bug 123256) to enable this feature again. I'd like to investigate why those regression occur on the bug.
Attachments
Patch (1.67 KB, patch)
2013-10-24 01:24 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.81 KB, patch)
2013-10-24 08:22 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-10-24 01:24:08 PDT
Created attachment 215036 [details] Patch
Gyuyoung Kim
Comment 2 2013-10-24 01:25:23 PDT
Added Martin and Carlos.
Martin Robinson
Comment 3 2013-10-24 06:43:17 PDT
Comment on attachment 215036 [details] Patch Are the tests skipped now or are they still failing on the bot?
Gyuyoung Kim
Comment 4 2013-10-24 07:50:26 PDT
(In reply to comment #3) > (From update of attachment 215036 [details]) > Are the tests skipped now or are they still failing on the bot? They are still failing on the bot. Do you want to skip them instead of disabling the css-image-orientation ?
Gyuyoung Kim
Comment 5 2013-10-24 08:22:17 PDT
Created attachment 215066 [details] Patch It looks Martin wants to skip failure tests instead of disabling this feature.
Martin Robinson
Comment 6 2013-10-24 08:30:47 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 215036 [details] [details]) > > Are the tests skipped now or are they still failing on the bot? > > They are still failing on the bot. Do you want to skip them instead of disabling the css-image-orientation ? Sorry, for the confusion. I didn't reply in time. I just wanted to ensure that if they were skipped, that your patch unskipped them. Since they aren't skipped now, this isn'tan issue. If you don't mind, I prefer your original patch.
Gyuyoung Kim
Comment 7 2013-10-24 08:32:37 PDT
Comment on attachment 215036 [details] Patch I want to handle this patch according to your guide.
WebKit Commit Bot
Comment 8 2013-10-24 08:58:29 PDT
Comment on attachment 215036 [details] Patch Clearing flags on attachment: 215036 Committed r157929: <http://trac.webkit.org/changeset/157929>
WebKit Commit Bot
Comment 9 2013-10-24 08:58:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.