Summary: | [WINCE]spin button of input tag of number is not panited | ||
---|---|---|---|
Product: | WebKit | Reporter: | Zhuang Zhigang <zhuangzg> |
Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan, paroga |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Other | ||
OS: | Other | ||
Attachments: |
Description
Zhuang Zhigang
2013-10-24 00:40:44 PDT
Created attachment 215046 [details]
paint spin button of number input for wince
Comment on attachment 215046 [details]
paint spin button of number input for wince
Please set the r? flag to get the patch reviewed and into the tree.
Attachment 215046 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.h']" exit_code: 1
Source/WebCore/rendering/RenderThemeWinCE.h:117: The parameter name "style" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/rendering/RenderThemeWinCE.h:117: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Source/WebCore/rendering/RenderThemeWinCE.h:118: The parameter name "i" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/rendering/RenderThemeWinCE.h:118: The parameter name "r" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/rendering/RenderThemeWinCE.cpp:676: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/rendering/RenderThemeWinCE.cpp:680: An else should appear on the same line as the preceding } [whitespace/newline] [4]
Source/WebCore/rendering/RenderThemeWinCE.cpp:680: Missing space before ( in if( [whitespace/parens] [5]
Source/WebCore/rendering/RenderThemeWinCE.cpp:681: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/rendering/RenderThemeWinCE.cpp:682: Missing space before ( in if( [whitespace/parens] [5]
Total errors found: 9 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 215641 [details]
a new patch that passed Tools/Scripts/check-webkit-style
Patrick, does this patch seem okay to you? (In reply to comment #5) > Patrick, does this patch seem okay to you? Yes, looks ok to me. Comment on attachment 215641 [details] a new patch that passed Tools/Scripts/check-webkit-style View in context: https://bugs.webkit.org/attachment.cgi?id=215641&action=review > Source/WebCore/rendering/RenderThemeWinCE.cpp:660 > +bool RenderThemeWinCE::paintInnerSpinButton(RenderObject* o, const PaintInfo& i, const IntRect& r) please rename "i" to "paintInfo", like in the other functions. Created attachment 215728 [details]
updated patch:rename "i" to "paintInfo"
(In reply to comment #7) > (From update of attachment 215641 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215641&action=review > > > Source/WebCore/rendering/RenderThemeWinCE.cpp:660 > > +bool RenderThemeWinCE::paintInnerSpinButton(RenderObject* o, const PaintInfo& i, const IntRect& r) > > please rename "i" to "paintInfo", like in the other functions. OK, "i" was renamed to "paintInfo". Please check the new patch! Comment on attachment 215728 [details]
updated patch:rename "i" to "paintInfo"
looks ok to me
Comment on attachment 215728 [details] updated patch:rename "i" to "paintInfo" View in context: https://bugs.webkit.org/attachment.cgi?id=215728&action=review Let's rephrase the ChangeLog slightly. Otherwise, it's ready to land. > Source/WebCore/ChangeLog:3 > + Paint spin button of input of number type on WinCE port. Let's rephrase this as "Implement spin control on WinCE port" Created attachment 215885 [details]
updated patch: rephrase the ChangeLog
(In reply to comment #11) > (From update of attachment 215728 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215728&action=review > > Let's rephrase the ChangeLog slightly. Otherwise, it's ready to land. > > > Source/WebCore/ChangeLog:3 > > + Paint spin button of input of number type on WinCE port. > > Let's rephrase this as "Implement spin control on WinCE port" OK! It was done. Please check it in new patch. Comment on attachment 215885 [details]
updated patch: rephrase the ChangeLog
Thanks for addressing those earlier comments. r=me!
Comment on attachment 215885 [details] updated patch: rephrase the ChangeLog Clearing flags on attachment: 215885 Committed r159534: <http://trac.webkit.org/changeset/159534> All reviewed patches have been landed. Closing bug. |