Bug 123207

Summary: Clean-up in Atomics.h
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Web Template FrameworkAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Allan Sandfeld Jensen
Reported 2013-10-23 07:35:12 PDT
Atomics.h has two confusing and bit-rotted ifdefs with comments. The first about CPU(SPARC64) was rendered obsolete when we switch from __exchange_and_add to __sync_add_and_fetch. The second was caused by a wrong definition that apparently only caused trouble on GCC.
Attachments
Patch (2.31 KB, patch)
2013-10-23 07:37 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (2.29 KB, patch)
2013-10-23 07:55 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-10-23 07:37:17 PDT
Created attachment 214959 [details] Patch
EFL EWS Bot
Comment 2 2013-10-23 07:42:02 PDT
Comment on attachment 214959 [details] Patch Attachment 214959 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/9858014
Allan Sandfeld Jensen
Comment 3 2013-10-23 07:55:12 PDT
Created attachment 214961 [details] Patch
WebKit Commit Bot
Comment 4 2013-10-23 10:40:23 PDT
Comment on attachment 214961 [details] Patch Clearing flags on attachment: 214961 Committed r157865: <http://trac.webkit.org/changeset/157865>
WebKit Commit Bot
Comment 5 2013-10-23 10:40:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.