Bug 123162

Summary: CTTE: Modernize RenderBlock a bit
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Sam Weinig
Reported 2013-10-22 07:16:03 PDT
CTTE: Modernize RenderBlock a bit
Attachments
Patch (282.30 KB, patch)
2013-10-22 07:17 PDT, Sam Weinig 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-10-22 07:17:18 PDT
Created attachment 214856 [details] Patch
Andreas Kling
Comment 2 2013-10-22 07:25:49 PDT
Comment on attachment 214856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214856&action=review > Source/WebCore/rendering/InlineIterator.h:199 > +static inline RenderObject* bidiNextShared(RenderElement& root, RenderObject* current, Observer* observer = 0, EmptyInlineBehavior emptyInlineBehavior = SkipEmptyInlines, bool* endOfInlinePtr = 0) 0 -> nullptr This comment repeated for each case of missing modernization!
Sam Weinig
Comment 3 2013-10-22 16:57:25 PDT
Committed r157828: <http://trac.webkit.org/changeset/157828>
Note You need to log in before you can comment on or make changes to this bug.