Bug 123136

Summary: [Cocoa] Add load delegate method for didChangeBackForwardList
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

mitz
Reported 2013-10-21 22:06:29 PDT
[Cocoa] Add load delegate method for didChangeBackForwardList
Attachments
Patch (3.51 KB, patch)
2013-10-21 22:08 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-10-21 22:08:09 PDT
Created attachment 214817 [details] Patch
Anders Carlsson
Comment 2 2013-10-21 22:13:39 PDT
Comment on attachment 214817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214817&action=review > Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:496 > + if ([browsingContext.loadDelegate respondsToSelector:@selector(browsingContextControllerDidChangedBackForwardList:addedItem:removedItems:)]) { I think this would look better with an early return (unless this is the parttern we're using elsewhere).
mitz
Comment 3 2013-10-21 22:15:16 PDT
Committed <http://trac.webkit.org/r157776>.
Note You need to log in before you can comment on or make changes to this bug.