Bug 123130

Summary: Remote Layer Tree: Implement superlayer, removeFromSuperlayer, replaceSublayer, and adoptSublayers
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
address sam's comments
none
we'll assert that they're PlatformCALayerRemotes in just one place andersca: review+

Tim Horton
Reported 2013-10-21 18:58:39 PDT
There are a few remaining unimplemented layer hierarchy properties that were left that way because they're more complicated than the others. But, we need them!
Attachments
patch (8.66 KB, patch)
2013-10-21 19:17 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
address sam's comments (10.03 KB, patch)
2013-10-22 11:37 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
we'll assert that they're PlatformCALayerRemotes in just one place (9.94 KB, patch)
2013-10-22 12:29 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-10-21 19:17:19 PDT
Created attachment 214807 [details] patch
Sam Weinig
Comment 2 2013-10-22 07:26:44 PDT
Comment on attachment 214807 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=214807&action=review > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:74 > + static_cast<PlatformCALayerRemote*>(layer.get())->m_superlayer = nullptr; Can we add a checked cast function for this (e.g. toPlatformCALayerRemote() that asserts the type is PlatformCALayerRemote)? > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h:157 > + PlatformCALayer* m_superlayer; Seems like m_superlayer is always a PlatformCALayerRemote. Can we make the type more specific here?
Tim Horton
Comment 3 2013-10-22 11:37:36 PDT
Created attachment 214872 [details] address sam's comments
Tim Horton
Comment 4 2013-10-22 12:29:48 PDT
Created attachment 214876 [details] we'll assert that they're PlatformCALayerRemotes in just one place
Anders Carlsson
Comment 5 2013-10-22 17:54:34 PDT
Comment on attachment 214876 [details] we'll assert that they're PlatformCALayerRemotes in just one place View in context: https://bugs.webkit.org/attachment.cgi?id=214876&action=review > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:154 > + PlatformCALayerList& siblings = m_children; I don't think you need to use this local variable. Also, it is misnamed.
Tim Horton
Comment 6 2013-10-23 01:23:52 PDT
http://trac.webkit.org/changeset/157852
Note You need to log in before you can comment on or make changes to this bug.