Bug 123120

Summary: Remove platform #ifdefs from WebDataSourcePrivate.h
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit APIAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ddkilzer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Daniel Bates
Reported 2013-10-21 15:13:19 PDT
WebKit API/SPI headers should not use platform #ifdefs. Currently we only declare the SPI functions -[WebDataSource _setAllowToBeMemoryMapped], -[WebDataSource setDataSourceDelegate:], and -[WebDataSource dataSourceDelegate] when building with disk image cache enabled on iOS. Instead we should always declare these functions and provide a trivial implementation for them when building with disk image cache disabled.
Attachments
Patch (3.46 KB, patch)
2013-10-21 15:18 PDT, Daniel Bates 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-10-21 15:17:08 PDT
<rdar://problem/15275533>
Daniel Bates
Comment 2 2013-10-21 15:18:31 PDT
Created attachment 214783 [details] Patch
Daniel Bates
Comment 3 2013-10-21 15:44:59 PDT
Committed r157753: <http://trac.webkit.org/changeset/157753>
Note You need to log in before you can comment on or make changes to this bug.