Bug 123107

Summary: [iOS] Upstream JSLock changes
Product: WebKit Reporter: Daniel Bates <dbates>
Component: JavaScriptCoreAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, barraclough, ggaren, mhahnenberg, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Daniel Bates
Reported 2013-10-21 11:14:22 PDT
Add support to hold a spin lock when acquiring and releasing locks. Additionally, implement support to optionally release all locks unconditionally as some client (e.g. Mobile Safari) may require this behavior. Currently, we only support releasing all locks conditionally.
Attachments
Patch (7.94 KB, patch)
2013-10-21 11:23 PDT, Daniel Bates 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-10-21 11:23:06 PDT
Created attachment 214754 [details] Patch
Daniel Bates
Comment 2 2013-10-21 11:25:12 PDT
See <rdar://problem/14171014> for the reasoning behind requiring a spin lock when acquiring or releasing all locks.
Daniel Bates
Comment 3 2013-10-21 11:27:00 PDT
See <rdar://problem/11231897> for details on implementing support to release all locks unconditionally.
Geoffrey Garen
Comment 4 2013-10-21 11:37:44 PDT
Comment on attachment 214754 [details] Patch I am so ashamed of this code :(.
Daniel Bates
Comment 5 2013-10-22 13:38:58 PDT
Committed r157809: <http://trac.webkit.org/changeset/157809>
Note You need to log in before you can comment on or make changes to this bug.