Bug 123083

Summary:

Use PassRef for StyleSheetContents.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, japhet, kangil.han, macpherson, menard, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Patch v2	koivisto: review+, buildbot: commit-queue-
Patch for landing	none

Andreas Kling

Reported 2013-10-20 06:19:28 PDT

Use PassRef for StyleSheetContents.

Attachments
Patch (19.27 KB, patch) 2013-10-20 06:20 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (455.11 KB, application/zip) 2013-10-20 07:24 PDT, Build Bot	no flags	Details
Patch v2 (19.32 KB, patch) 2013-10-20 07:41 PDT, Andreas Kling	koivisto: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Patch for landing (22.18 KB, patch) 2013-10-20 08:40 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-10-20 06:20:31 PDT

Created attachment 214697 [details] Patch

Build Bot

Comment 2 2013-10-20 07:13:50 PDT

Comment on attachment 214697 [details] Patch Attachment 214697 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/6798029

Build Bot

Comment 3 2013-10-20 07:23:59 PDT

Comment on attachment 214697 [details] Patch Attachment 214697 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/7448037 New failing tests: fast/dom/StyleSheet/detached-style-2.html

Build Bot

Comment 4 2013-10-20 07:24:02 PDT

Created attachment 214699 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Andreas Kling

Comment 5 2013-10-20 07:41:30 PDT

Created attachment 214700 [details] Patch v2

Antti Koivisto

Comment 6 2013-10-20 08:17:51 PDT

Comment on attachment 214700 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=214700&action=review > Source/WebCore/css/CSSStyleSheet.h:51 > - static PassRefPtr<CSSStyleSheet> create(PassRefPtr<StyleSheetContents>, CSSImportRule* ownerRule = 0); > - static PassRefPtr<CSSStyleSheet> create(PassRefPtr<StyleSheetContents>, Node* ownerNode); > + static PassRefPtr<CSSStyleSheet> create(PassRef<StyleSheetContents>, CSSImportRule* ownerRule = 0); > + static PassRefPtr<CSSStyleSheet> create(PassRef<StyleSheetContents>, Node* ownerNode); Why not PassRef return? > Source/WebCore/css/CSSStyleSheet.h:114 > - StyleSheetContents* contents() const { return m_contents.get(); } > + StyleSheetContents* contents() { return &m_contents.get(); } Reference?

Build Bot

Comment 7 2013-10-20 08:32:59 PDT

Comment on attachment 214700 [details] Patch v2 Attachment 214700 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/7628027

Andreas Kling

Comment 8 2013-10-20 08:40:27 PDT

Created attachment 214703 [details] Patch for landing

WebKit Commit Bot

Comment 9 2013-10-20 09:10:29 PDT

Comment on attachment 214703 [details] Patch for landing Clearing flags on attachment: 214703 Committed r157702: <http://trac.webkit.org/changeset/157702>

WebKit Commit Bot

Comment 10 2013-10-20 09:10:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.