Summary: | Use PassRef for StyleSheetContents. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||
Component: | CSS | Assignee: | Andreas Kling <kling> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, japhet, kangil.han, macpherson, menard, rniwa | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Andreas Kling
2013-10-20 06:19:28 PDT
Created attachment 214697 [details]
Patch
Comment on attachment 214697 [details] Patch Attachment 214697 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/6798029 Comment on attachment 214697 [details] Patch Attachment 214697 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/7448037 New failing tests: fast/dom/StyleSheet/detached-style-2.html Created attachment 214699 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 214700 [details]
Patch v2
Comment on attachment 214700 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=214700&action=review > Source/WebCore/css/CSSStyleSheet.h:51 > - static PassRefPtr<CSSStyleSheet> create(PassRefPtr<StyleSheetContents>, CSSImportRule* ownerRule = 0); > - static PassRefPtr<CSSStyleSheet> create(PassRefPtr<StyleSheetContents>, Node* ownerNode); > + static PassRefPtr<CSSStyleSheet> create(PassRef<StyleSheetContents>, CSSImportRule* ownerRule = 0); > + static PassRefPtr<CSSStyleSheet> create(PassRef<StyleSheetContents>, Node* ownerNode); Why not PassRef return? > Source/WebCore/css/CSSStyleSheet.h:114 > - StyleSheetContents* contents() const { return m_contents.get(); } > + StyleSheetContents* contents() { return &m_contents.get(); } Reference? Comment on attachment 214700 [details] Patch v2 Attachment 214700 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/7628027 Created attachment 214703 [details]
Patch for landing
Comment on attachment 214703 [details] Patch for landing Clearing flags on attachment: 214703 Committed r157702: <http://trac.webkit.org/changeset/157702> All reviewed patches have been landed. Closing bug. |