Bug 123075

Summary:

Removing "unused parameter" compiling warnings from WebKit2 and WebCore

Product:

WebKit

Reporter:

Thiago de Barros Lacerda <thiago.lacerda>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andersca, apinheiro, benjamin, cfleizach, commit-queue, dmazzoni, eric.carlson, glenn, gustavo, hta, jdiggs, jer.noble, kling, mario, menard, mrobinson, pnormand, tommyw

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Thiago de Barros Lacerda

Reported 2013-10-19 19:45:35 PDT

Removing general compiling warnings from WebKit2 and WebCore

Attachments
Patch (15.18 KB, patch) 2013-10-19 19:49 PDT, Thiago de Barros Lacerda	no flags	Details Formatted Diff Diff
Patch (15.17 KB, patch) 2013-10-20 06:38 PDT, Thiago de Barros Lacerda	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Thiago de Barros Lacerda

Comment 1 2013-10-19 19:49:01 PDT

Created attachment 214684 [details] Patch

Anders Carlsson

Comment 2 2013-10-19 21:39:40 PDT

Comment on attachment 214684 [details] Patch Looks like these are all unused parameter warnings? If so, could you update the title of the bug and ChangeLog?

Thiago de Barros Lacerda

Comment 3 2013-10-20 06:29:18 PDT

(In reply to comment #2) > (From update of attachment 214684 [details]) > Looks like these are all unused parameter warnings? If so, could you update the title of the bug and ChangeLog? Sure :)

Thiago de Barros Lacerda

Comment 4 2013-10-20 06:38:36 PDT

Created attachment 214698 [details] Patch

WebKit Commit Bot

Comment 5 2013-10-20 07:14:15 PDT

Comment on attachment 214698 [details] Patch Clearing flags on attachment: 214698 Committed r157700: <http://trac.webkit.org/changeset/157700>

WebKit Commit Bot

Comment 6 2013-10-20 07:14:19 PDT

All reviewed patches have been landed. Closing bug.

Hugo Parente Lima

Comment 7 2013-10-21 10:27:22 PDT

Comment on attachment 214698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214698&action=review > Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47 > ASSERT(type == eventNames().tonechangeEvent); Remove the type parameter will break the debug build due to the assert using it.

Thiago de Barros Lacerda

Comment 8 2013-10-21 10:45:26 PDT

(In reply to comment #7) > (From update of attachment 214698 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214698&action=review > > > Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47 > > ASSERT(type == eventNames().tonechangeEvent); > > Remove the type parameter will break the debug build due to the assert using it. Sorry, you are right. Didn't pay attention to the debug build because I thought that the build bots would alert me. Maybe they don't have MediaStream enabled. Fixing that in other patch now

Note You need to log in before you can comment on or make changes to this bug.