Bug 123073

Summary: Adding test case for text-decoration property state change on applying different command
Product: WebKit Reporter: Santosh Mahto <santosh.ma>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing none

Santosh Mahto
Reported 2013-10-19 16:05:17 PDT
This test case verify text-decoration property state on element after applying editing commands related to text-decoration.
Attachments
Patch (7.56 KB, patch)
2013-10-19 16:09 PDT, Santosh Mahto 		no flags
DetailsFormatted DiffDiff
patch for landing (7.67 KB, patch)
2013-10-19 16:45 PDT, Santosh Mahto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Santosh Mahto
Comment 1 2013-10-19 16:09:27 PDT
Created attachment 214679 [details] Patch
Ryosuke Niwa
Comment 2 2013-10-19 16:32:01 PDT
Comment on attachment 214679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214679&action=review > LayoutTests/editing/style/text-decoration-state-change.html:39 > + var e = document.getElementById('e'); > + var s = window.getSelection(); > + var r = document.createRange(); > + r.setStart(e, 0); > + r.setEnd(e, 1); > + e.focus(); > + s.removeAllRanges(); > + s.addRange(r); Please don't use one letter variables.
Santosh Mahto
Comment 3 2013-10-19 16:45:00 PDT
Created attachment 214681 [details] patch for landing
WebKit Commit Bot
Comment 4 2013-10-19 17:23:01 PDT
Comment on attachment 214681 [details] patch for landing Clearing flags on attachment: 214681 Committed r157689: <http://trac.webkit.org/changeset/157689>
WebKit Commit Bot
Comment 5 2013-10-19 17:23:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.