Bug 123065

Summary:

[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

124850

Bug Blocks:

Attachments:

Description	Flags
Remove private _data ivars from interfaces	sam: review+
Remove private _data ivars from interfaces	none

mitz

Reported 2013-10-19 12:31:51 PDT

[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime

Attachments
Remove private _data ivars from interfaces (25.93 KB, patch) 2013-10-19 12:45 PDT, mitz	sam: review+	Details Formatted Diff Diff
Remove private _data ivars from interfaces (30.41 KB, patch) 2013-11-25 14:29 PST, mitz	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2013-10-19 12:45:18 PDT

Created attachment 214660 [details] Remove private _data ivars from interfaces

Sam Weinig

Comment 2 2013-10-19 13:15:19 PDT

Comment on attachment 214660 [details] Remove private _data ivars from interfaces Nice. r=me.

mitz

Comment 3 2013-10-19 13:16:53 PDT

Landed in <http://trac.webkit.org/r157676>.

Alexey Proskuryakov

Comment 4 2013-10-19 13:41:31 PDT

This broke 32-bit build, <http://build.webkit.org/builders/Apple%20MountainLion%20Release%20(32-bit%20Build)/builds/4983/steps/compile-webkit/logs/stdio/text>

mitz

Comment 5 2013-10-19 13:43:06 PDT

(In reply to comment #4) > This broke 32-bit build, <http://build.webkit.org/builders/Apple%20MountainLion%20Release%20(32-bit%20Build)/builds/4983/steps/compile-webkit/logs/stdio/text> I’m on it.

mitz

Comment 6 2013-10-19 14:34:56 PDT

I reverted everything in r157681. I can attempt this again when I have a 32-bit build.

mitz

Comment 7 2013-11-25 12:14:59 PST

Going to try something like this again after bug 124850 is fixed.

mitz

Comment 8 2013-11-25 14:29:28 PST

Created attachment 217832 [details] Remove private _data ivars from interfaces

WebKit Commit Bot

Comment 9 2013-11-25 15:47:54 PST

Comment on attachment 217832 [details] Remove private _data ivars from interfaces Clearing flags on attachment: 217832 Committed r159770: <http://trac.webkit.org/changeset/159770>

WebKit Commit Bot

Comment 10 2013-11-25 15:47:56 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.