Bug 123064

Summary: REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Blocker CC: ap, commit-queue, lforschler, rniwa
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryosuke Niwa
Reported 2013-10-19 11:57:50 PDT
http://trac.webkit.org/changeset/155373 regressed port detection mechanism in EWS. This patch needs to be either rolled out manually or the regression needs to be fixed ASAP.
Attachments
Patch (38.38 KB, patch)
2013-10-19 14:11 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (57.17 KB, patch)
2013-10-19 14:16 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-10-19 12:00:41 PDT
Seriously, EWS needs to be rewritten. The current implementation is too fragile. And we need to stop doing these refactoring until that's done because we're going to break things one way or another in the current state.
Zan Dobersek
Comment 2 2013-10-19 14:11:27 PDT
Created attachment 214668 [details] Patch
WebKit Commit Bot
Comment 3 2013-10-19 14:13:04 PDT
Attachment 214668 [details] did not pass style-queue: Traceback (most recent call last): File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch", line 44, in <module> from webkitpy.tool.main import WebKitPatch File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/main.py", line 36, in <module> from webkitpy.common.config.ports import DeprecatedPort ImportError: No module named ports If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 4 2013-10-19 14:15:36 PDT
Comment on attachment 214668 [details] Patch r=me provided the deleted files are being added. Thanks!
Zan Dobersek
Comment 5 2013-10-19 14:16:47 PDT
Created attachment 214669 [details] Patch
Zan Dobersek
Comment 6 2013-10-19 14:23:41 PDT
Comment on attachment 214669 [details] Patch Clearing flags on attachment: 214669 Committed r157682: <http://trac.webkit.org/changeset/157682>
Zan Dobersek
Comment 7 2013-10-19 14:23:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.