Bug 123045

Summary: [iOS] Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout()
Product: WebKit Reporter: Daniel Bates <dbates>
Component: JavaScriptCoreAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, buildbot, commit-queue, darin, eflews.bot, ggaren, gyuyoung.kim, japhet, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch joepeck: review+

Daniel Bates
Reported 2013-10-18 16:16:00 PDT
Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout() and JSDOMWindowBase::shouldInterruptScriptBeforeTimeout().
Attachments
Patch (11.02 KB, patch)
2013-10-18 16:19 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (10.71 KB, patch)
2013-10-18 17:10 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (13.45 KB, patch)
2013-10-21 08:33 PDT, Daniel Bates 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-10-18 16:19:54 PDT
Created attachment 214612 [details] Patch I plan to post the iOS chrome client implementation in a subsequent patch.
EFL EWS Bot
Comment 2 2013-10-18 16:40:55 PDT
Comment on attachment 214612 [details] Patch Attachment 214612 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/6408029
Build Bot
Comment 3 2013-10-18 16:48:31 PDT
Comment on attachment 214612 [details] Patch Attachment 214612 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6458021
Daniel Bates
Comment 4 2013-10-18 17:10:41 PDT
Created attachment 214620 [details] Patch
Build Bot
Comment 5 2013-10-18 17:50:43 PDT
Comment on attachment 214620 [details] Patch Attachment 214620 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4918029
EFL EWS Bot
Comment 6 2013-10-18 18:06:34 PDT
Comment on attachment 214620 [details] Patch Attachment 214620 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/5848035
Build Bot
Comment 7 2013-10-18 18:18:17 PDT
Comment on attachment 214620 [details] Patch Attachment 214620 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5778027
Build Bot
Comment 8 2013-10-18 19:16:20 PDT
Comment on attachment 214620 [details] Patch Attachment 214620 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5858056
EFL EWS Bot
Comment 9 2013-10-20 11:14:59 PDT
Comment on attachment 214620 [details] Patch Attachment 214620 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/7828005
Daniel Bates
Comment 10 2013-10-21 08:33:02 PDT
Created attachment 214742 [details] Patch
Joseph Pecoraro
Comment 11 2013-10-21 16:45:38 PDT
Comment on attachment 214742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214742&action=review r=me > Source/WebCore/loader/EmptyClients.h:195 > + virtual bool isStopping() OVERRIDE { return false }; Would this build? I think the semicolon at the end of the line should be after "return false".
Daniel Bates
Comment 12 2013-10-21 16:50:12 PDT
(In reply to comment #11) > > Source/WebCore/loader/EmptyClients.h:195 > > + virtual bool isStopping() OVERRIDE { return false }; > > Would this build? I think the semicolon at the end of the line should be after "return false". Will fix before landing.
Daniel Bates
Comment 13 2013-10-21 16:52:53 PDT
Committed r157764: <http://trac.webkit.org/changeset/157764>
Note You need to log in before you can comment on or make changes to this bug.