| Summary: | Group 64-bit specific and 32-bit specific callOperation implementations in JITInlines.h | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Brianceau <jbriance> | ||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, msaboff | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 214576 [details]
Put 64-bit callOperation implementations under USE(JSVALUE64) condition.
There are few other functions involved actually.
Comment on attachment 214576 [details]
Put 64-bit callOperation implementations under USE(JSVALUE64) condition.
r+ Please group these together similar to what's in DFGSpeculativeJIT.h.
Comment on attachment 214576 [details]
Put 64-bit callOperation implementations under USE(JSVALUE64) condition.
Needs grouping
Created attachment 214578 [details]
Group 64-bit specific and 32-bit specific callOperation implementations
Created attachment 214582 [details] Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased) Rebase on top of r157636 Comment on attachment 214578 [details] Group 64-bit specific and 32-bit specific callOperation implementations Patch will fail to r157636 Comment on attachment 214582 [details] Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased) Clearing flags on attachment: 214582 Committed r157639: <http://trac.webkit.org/changeset/157639> All reviewed patches have been landed. Closing bug. |
The following functions in jit/JITInlines.h should be under #if USE(JSVALUE64) condition: ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(J_JITOperation_EJJ operation, int dst, GPRReg arg1, GPRReg arg2) { setupArgumentsWithExecState(arg1, arg2); return appendCallWithExceptionCheckSetJSValueResult(operation, dst); } ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(S_JITOperation_EJJ operation, RegisterID regOp1, RegisterID regOp2) { setupArgumentsWithExecState(regOp1, regOp2); return appendCallWithExceptionCheck(operation); } This is not a big deal, but could be a bit confusing when reading the code.