Bug 123024

Summary:

Group 64-bit specific and 32-bit specific callOperation implementations in JITInlines.h

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, msaboff

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Put 64-bit callOperation implementations under USE(JSVALUE64) condition.	none
Group 64-bit specific and 32-bit specific callOperation implementations	msaboff: review+, jbriance: commit-queue-
Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased)	none

Julien Brianceau

Reported 2013-10-18 08:18:19 PDT

The following functions in jit/JITInlines.h should be under #if USE(JSVALUE64) condition: ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(J_JITOperation_EJJ operation, int dst, GPRReg arg1, GPRReg arg2) { setupArgumentsWithExecState(arg1, arg2); return appendCallWithExceptionCheckSetJSValueResult(operation, dst); } ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(S_JITOperation_EJJ operation, RegisterID regOp1, RegisterID regOp2) { setupArgumentsWithExecState(regOp1, regOp2); return appendCallWithExceptionCheck(operation); } This is not a big deal, but could be a bit confusing when reading the code.

Attachments
Put 64-bit callOperation implementations under USE(JSVALUE64) condition. (4.31 KB, patch) 2013-10-18 08:39 PDT, Julien Brianceau	no flags	Details Formatted Diff Diff
Group 64-bit specific and 32-bit specific callOperation implementations (16.61 KB, patch) 2013-10-18 09:10 PDT, Julien Brianceau	msaboff: review+ jbriance: commit-queue-	Details Formatted Diff Diff
Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased) (16.14 KB, patch) 2013-10-18 09:38 PDT, Julien Brianceau	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Julien Brianceau

Comment 1 2013-10-18 08:39:38 PDT

Created attachment 214576 [details] Put 64-bit callOperation implementations under USE(JSVALUE64) condition. There are few other functions involved actually.

Michael Saboff

Comment 2 2013-10-18 08:50:54 PDT

Comment on attachment 214576 [details] Put 64-bit callOperation implementations under USE(JSVALUE64) condition. r+ Please group these together similar to what's in DFGSpeculativeJIT.h.

Julien Brianceau

Comment 3 2013-10-18 08:51:26 PDT

Comment on attachment 214576 [details] Put 64-bit callOperation implementations under USE(JSVALUE64) condition. Needs grouping

Julien Brianceau

Comment 4 2013-10-18 09:10:22 PDT

Created attachment 214578 [details] Group 64-bit specific and 32-bit specific callOperation implementations

Julien Brianceau

Comment 5 2013-10-18 09:38:35 PDT

Created attachment 214582 [details] Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased) Rebase on top of r157636

Julien Brianceau

Comment 6 2013-10-18 09:44:04 PDT

Comment on attachment 214578 [details] Group 64-bit specific and 32-bit specific callOperation implementations Patch will fail to r157636

WebKit Commit Bot

Comment 7 2013-10-18 10:02:14 PDT

Comment on attachment 214582 [details] Group 64-bit specific and 32-bit specific callOperation implementations (r157636 rebased) Clearing flags on attachment: 214582 Committed r157639: <http://trac.webkit.org/changeset/157639>

WebKit Commit Bot

Comment 8 2013-10-18 10:02:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.