| Summary: | [mips][arm EABI] Fix J_JITOperation_EAapJ call in JIT. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Brianceau <jbriance> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, kilvadyb, msaboff, ossy, yong.li.webkit | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 108645 | ||||||
| Attachments: |
|
||||||
Created attachment 214572 [details]
Fix J_JITOperation_EAapJ call for MIPS and ARM EABI.
Comment on attachment 214572 [details] Fix J_JITOperation_EAapJ call for MIPS and ARM EABI. Clearing flags on attachment: 214572 Committed r157633: <http://trac.webkit.org/changeset/157633> All reviewed patches have been landed. Closing bug. |
EABI_32BIT_DUMMY_ARG is not expected in the following function, the EncodedJSValue parameter is already aligned to even registers for MIPS and ARM EABI (in 3rd and 4th argument registers): ALWAYS_INLINE MacroAssembler::Call JIT::callOperation(J_JITOperation_EAapJ operation, int dst, ArrayAllocationProfile* arg1, GPRReg arg2Tag, GPRReg arg2Payload) { setupArgumentsWithExecState(TrustedImmPtr(arg1), EABI_32BIT_DUMMY_ARG arg2Payload, arg2Tag); return appendCallWithExceptionCheckSetJSValueResult(operation, dst); }