Bug 123004 – Antialias underlines if they're not axis-aligned

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Antialias underlines if they're not axis-aligned

[Myles C. Maxfield]

Created attachment 214905 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/15299802>

[Simon Fraser (smfr)]

Comment on attachment 214905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214905&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1256
> +    if (!printing && getCTM(GraphicsContext::DefinitelyIncludeDeviceScale).preservesAxisAlignment()) {

This is going to be a light perf hit, but not sure if it is measurable.

[WebKit Commit Bot]

Comment on attachment 214905 [details]
Patch

Rejecting attachment 214905 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 214905, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6078091

[Myles C. Maxfield]

Created attachment 214978 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 214978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214978&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Tests: svg/custom/foreign-object-skew.html

You need to explain the change.

[Myles C. Maxfield]

Created attachment 214979 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 214979 [details]
Patch

Clearing flags on attachment: 214979

Committed r157878: <http://trac.webkit.org/changeset/157878>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.