Bug 12297

Summary: Debug flag to output mark traces to stdio
Product: WebKit Reporter: Sanjay Madhav (chmmravatar) <sanjay12>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
mark trace debug output
none
formatting fixed
darin: review+
updated as per notes none

Sanjay Madhav (chmmravatar)
Reported 2007-01-17 02:12:25 PST
While tracking down bug #10733, I added in some debug output to JSObject::mark, which helped tremendously to figure out who was marking what precisely. Setting the JAVASCRIPT_MARK_TRACE define to 1 will give you output similar to this: http://paste.lisp.org/display/35471 . Though the patch attached additionally will show the memory address of the object in parenthesis.
Attachments
mark trace debug output (864 bytes, patch)
2007-01-17 02:15 PST, Sanjay Madhav (chmmravatar) 		no flags
DetailsFormatted DiffDiff
formatting fixed (1.29 KB, patch)
2007-01-17 02:41 PST, Sanjay Madhav (chmmravatar) 		darin: review+
DetailsFormatted DiffDiff
updated as per notes (1.24 KB, patch)
2007-01-17 09:40 PST, Sanjay Madhav (chmmravatar) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sanjay Madhav (chmmravatar)
Comment 1 2007-01-17 02:15:01 PST
Created attachment 12499 [details] mark trace debug output
Sanjay Madhav (chmmravatar)
Comment 2 2007-01-17 02:41:02 PST
Created attachment 12500 [details] formatting fixed
Darin Adler
Comment 3 2007-01-17 07:33:15 PST
Comment on attachment 12500 [details] formatting fixed I would have named the variable markStackDepth myself. className().UTF8String().c_str() would be slightly better than className().ascii(). r=me
Darin Adler
Comment 4 2007-01-17 07:34:23 PST
Comment on attachment 12500 [details] formatting fixed Might also be faster to use putchar or putc instead of printf to write the "-" characters.
Sanjay Madhav (chmmravatar)
Comment 5 2007-01-17 09:40:27 PST
Created attachment 12511 [details] updated as per notes
Mark Rowe (bdash)
Comment 6 2007-01-18 17:18:37 PST
Landed in r18963.
Note You need to log in before you can comment on or make changes to this bug.