Bug 122953

Summary: DataRef<T> should use Ref<T> internally.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, kling, kondapallykalyan, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, eflews.bot: commit-queue-
Patch for landing none

Andreas Kling
Reported 2013-10-17 03:51:49 PDT
DataRef never wraps a null pointer, so it should use Ref internally to avoid unnecessary null checks.
Attachments
Patch (30.18 KB, patch)
2013-10-17 04:06 PDT, Andreas Kling 		koivisto: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (30.87 KB, patch)
2013-10-17 04:52 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-17 04:06:22 PDT
Created attachment 214439 [details] Patch
EFL EWS Bot
Comment 2 2013-10-17 04:15:07 PDT
Comment on attachment 214439 [details] Patch Attachment 214439 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/4110430
kov's GTK+ EWS bot
Comment 3 2013-10-17 04:21:27 PDT
Comment on attachment 214439 [details] Patch Attachment 214439 [details] did not pass gtk-wk2-ews (gtk-wk2): Output: http://webkit-queues.appspot.com/results/4105473
Build Bot
Comment 4 2013-10-17 04:49:14 PDT
Comment on attachment 214439 [details] Patch Attachment 214439 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3476033
Andreas Kling
Comment 5 2013-10-17 04:52:10 PDT
Created attachment 214440 [details] Patch for landing
Andreas Kling
Comment 6 2013-10-17 05:14:15 PDT
Committed r157568: <http://trac.webkit.org/changeset/157568>
Note You need to log in before you can comment on or make changes to this bug.