Bug 122941

Summary: Introduce WTF::Bag and start using it for InlineCallFrameSet
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rakuco, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 122940    
Attachments:
Description Flags
the patch
none
the patch ggaren: review+

Filip Pizlo
Reported 2013-10-16 21:51:44 PDT
Because SegmentedVector is an abomination and using Vector as an allocation pool is totally insane
Attachments
the patch (16.24 KB, patch)
2013-10-16 22:24 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (16.27 KB, patch)
2013-10-16 22:37 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-10-16 22:24:16 PDT
Created attachment 214420 [details] the patch
WebKit Commit Bot
Comment 2 2013-10-16 22:26:45 PDT
Attachment 214420 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/InlineCallFrameSet.cpp', u'Source/JavaScriptCore/bytecode/InlineCallFrameSet.h', u'Source/JavaScriptCore/dfg/DFGArgumentsSimplificationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGJITCompiler.cpp', u'Source/JavaScriptCore/dfg/DFGStackLayoutPhase.cpp', u'Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmakefile.list.am', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/Bag.h', u'Source/WTF/wtf/CMakeLists.txt']" exit_code: 1 Source/JavaScriptCore/bytecode/InlineCallFrameSet.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2013-10-16 22:37:51 PDT
Created attachment 214421 [details] the patch Fix style.
Geoffrey Garen
Comment 4 2013-10-17 00:16:03 PDT
Comment on attachment 214421 [details] the patch r=me
Filip Pizlo
Comment 5 2013-10-17 08:46:03 PDT
Landed in http://trac.webkit.org/changeset/157576
Note You need to log in before you can comment on or make changes to this bug.