Bug 122935

Summary: Support multiple repositories in submitting results to --results-server-host
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dfarler, glenn, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug andersca: review+

Ryosuke Niwa
Reported 2013-10-16 19:24:17 PDT
Support multiple repositories in submitting results to --results-server-host
Attachments
Fixes the bug (5.07 KB, patch)
2013-10-16 19:24 PDT, Ryosuke Niwa 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-10-16 19:24:52 PDT
Created attachment 214415 [details] Fixes the bug
Alexey Proskuryakov
Comment 2 2013-10-16 19:30:18 PDT
Comment on attachment 214415 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402 > + ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name), # FIXME: Pass in build.webkit.org. webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard?
Ryosuke Niwa
Comment 3 2013-10-16 19:31:47 PDT
(In reply to comment #2) > (From update of attachment 214415 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402 > > + ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name), # FIXME: Pass in build.webkit.org. > > webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard? This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating.
Ryosuke Niwa
Comment 4 2013-10-16 19:35:08 PDT
Committed r157553: <http://trac.webkit.org/changeset/157553>
Alexey Proskuryakov
Comment 5 2013-10-16 19:36:29 PDT
Comment on attachment 214415 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review >>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402 >>> + ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name), # FIXME: Pass in build.webkit.org. >> >> webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard? > > This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating. It's super confusing that code in layout_tests/controllers/manager.py is not universal.
Ryosuke Niwa
Comment 6 2013-10-16 19:40:59 PDT
(In reply to comment #5) > (From update of attachment 214415 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review > > >>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402 > >>> + ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name), # FIXME: Pass in build.webkit.org. > >> > >> webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard? > > > > This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating. > > It's super confusing that code in layout_tests/controllers/manager.py is not universal. Well, the idea is to get rid of the old code because it's a bloated mess.
Note You need to log in before you can comment on or make changes to this bug.