Bug 122933

Summary: Remote Layer Tree: Complete support for simple layer properties
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch andersca: review+

Tim Horton
Reported 2013-10-16 18:20:58 PDT
A few more properties: maskLayer, contentsRect, contentsScale, minificationFilter, magnificationFilter, speed, and timeOffset. And, associated cleanup. This completes the set of straightforward PlatformCALayerRemote properties (ignoring contents, filters, animations, and hierarchy).
Attachments
patch (25.15 KB, patch)
2013-10-16 18:29 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-10-16 18:29:58 PDT
Created attachment 214412 [details] patch
Anders Carlsson
Comment 2 2013-10-16 18:36:26 PDT
Comment on attachment 214412 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=214412&action=review > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:121 > + ASSERT(layer->isRemote()); > + if (!layer->isRemote()) > + return; No need for both an ASSERT and an early return since this only runs with assertions enabled.
Tim Horton
Comment 3 2013-10-16 18:45:09 PDT
http://trac.webkit.org/changeset/157547
Note You need to log in before you can comment on or make changes to this bug.