Bug 122928

Summary: Remove unnecessary check for RenderLayer and rename ensureLayer to createLayer in RenderLayerModelObject.
Product: WebKit Reporter: Vivek Galatage <vivekg>
Component: Layout and RenderingAssignee: Vivek Galatage <vivekg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Vivek Galatage
Reported 2013-10-16 16:58:41 PDT
RenderLayerModelObject::styleDidChange() invokes the ensureLayer() method only in case of !layer(). Again checking for layer existence would be deemed redundant in ensureLayer. Replacing it with an ASSERT(!m_layer). Blink Review URL: https://codereview.chromium.org/27246003/
Attachments
Patch (3.00 KB, patch)
2013-10-16 17:04 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2013-10-16 17:04:48 PDT
Created attachment 214406 [details] Patch
WebKit Commit Bot
Comment 2 2013-10-17 12:13:44 PDT
Comment on attachment 214406 [details] Patch Clearing flags on attachment: 214406 Committed r157587: <http://trac.webkit.org/changeset/157587>
WebKit Commit Bot
Comment 3 2013-10-17 12:13:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.