Bug 122885

Summary: Remove more of the UNINTERRUPTED_SEQUENCE thing
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, yannick.poirier
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Remove beginUninterruptedSequence and endUninterruptedSequence functions
none
Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) none

Julien Brianceau
Reported 2013-10-16 00:05:00 PDT
The UNINTERRUPTED_SEQUENCE thing was not completely removed by http://trac.webkit.org/changeset/157481: the 2 following function implementation remain in JITInlines.h file, leading to build failure for SH4 architure. void JIT::beginUninterruptedSequence(int, int); void JIT::endUninterruptedSequence(int, int, int);
Attachments
Remove beginUninterruptedSequence and endUninterruptedSequence functions (2.93 KB, patch)
2013-10-16 00:09 PDT, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) (3.59 KB, patch)
2013-10-16 00:56 PDT, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-10-16 00:09:32 PDT
Created attachment 214345 [details] Remove beginUninterruptedSequence and endUninterruptedSequence functions Fix the following compilation error: In file included from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITCall32_64.cpp:35:0: /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITInlines.h:121:81: error: no ‘void JSC::JIT::beginUninterruptedSequence(int, int)’ member function declared in class ‘JSC::JIT’ /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITInlines.h:147:88: error: no ‘void JSC::JIT::endUninterruptedSequence(int, int, int)’ member function declared in class ‘JSC::JIT’
Julien Brianceau
Comment 2 2013-10-16 00:20:58 PDT
Comment on attachment 214345 [details] Remove beginUninterruptedSequence and endUninterruptedSequence functions I forgot to remove something else, I'll submit another patch soon
Julien Brianceau
Comment 3 2013-10-16 00:56:39 PDT
Created attachment 214346 [details] Remove beginUninterruptedSequence and endUninterruptedSequence functions (2)
Andreas Kling
Comment 4 2013-10-16 01:15:14 PDT
Comment on attachment 214346 [details] Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) rs=me
WebKit Commit Bot
Comment 5 2013-10-16 01:39:17 PDT
Comment on attachment 214346 [details] Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) Clearing flags on attachment: 214346 Committed r157500: <http://trac.webkit.org/changeset/157500>
WebKit Commit Bot
Comment 6 2013-10-16 01:39:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.