Bug 122877

Summary: Get rid of the StructureStubInfo::patch union
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 121641    
Attachments:
Description Flags
the patch
none
the patch
none
the patch sam: review+

Filip Pizlo
Reported 2013-10-15 19:48:40 PDT
The baseline JIT part of this isn't used anymore.
Attachments
the patch (39.44 KB, patch)
2013-10-15 19:50 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (39.77 KB, patch)
2013-10-15 19:51 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (39.91 KB, patch)
2013-10-15 19:53 PDT, Filip Pizlo 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-10-15 19:50:00 PDT
Created attachment 214333 [details] the patch
WebKit Commit Bot
Comment 2 2013-10-15 19:50:46 PDT
Attachment 214333 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/StructureStubInfo.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.cpp', u'Source/JavaScriptCore/jit/JIT.cpp', u'Source/JavaScriptCore/jit/Repatch.cpp']" exit_code: 1 Source/JavaScriptCore/jit/Repatch.cpp:562: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2013-10-15 19:51:33 PDT
Created attachment 214334 [details] the patch
Filip Pizlo
Comment 4 2013-10-15 19:53:27 PDT
Created attachment 214335 [details] the patch
Filip Pizlo
Comment 5 2013-10-15 21:31:46 PDT
Landed in http://trac.webkit.org/changeset/157489
Note You need to log in before you can comment on or make changes to this bug.