Bug 122877 - Get rid of the StructureStubInfo::patch union
Summary: Get rid of the StructureStubInfo::patch union
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 121641
  Show dependency treegraph
 
Reported: 2013-10-15 19:48 PDT by Filip Pizlo
Modified: 2013-10-15 21:31 PDT (History)
8 users (show)

See Also:


Attachments
the patch (39.44 KB, patch)
2013-10-15 19:50 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (39.77 KB, patch)
2013-10-15 19:51 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (39.91 KB, patch)
2013-10-15 19:53 PDT, Filip Pizlo
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-15 19:48:40 PDT
The baseline JIT part of this isn't used anymore.
Comment 1 Filip Pizlo 2013-10-15 19:50:00 PDT
Created attachment 214333 [details]
the patch
Comment 2 WebKit Commit Bot 2013-10-15 19:50:46 PDT
Attachment 214333 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/StructureStubInfo.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.cpp', u'Source/JavaScriptCore/jit/JIT.cpp', u'Source/JavaScriptCore/jit/Repatch.cpp']" exit_code: 1
Source/JavaScriptCore/jit/Repatch.cpp:562:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2013-10-15 19:51:33 PDT
Created attachment 214334 [details]
the patch
Comment 4 Filip Pizlo 2013-10-15 19:53:27 PDT
Created attachment 214335 [details]
the patch
Comment 5 Filip Pizlo 2013-10-15 21:31:46 PDT
Landed in http://trac.webkit.org/changeset/157489