Bug 122864

Summary:

GenerateIsReachable=ImplContext is confusing

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebGL

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dino, eflews.bot, esprehn+autocc, gyuyoung.kim, kondapallykalyan, mhahnenberg, philn, roger_fong, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
with ChangeLog updated	ggaren: review+, eflews.bot: commit-queue-
patch for landing	commit-queue: commit-queue-
you not trust me?	none

Alexey Proskuryakov

Reported 2013-10-15 14:35:22 PDT

We have lots of contexts. I initially thought that this was about ScriptExecutionContext.

Attachments
proposed patch (9.76 KB, patch) 2013-10-15 14:44 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
with ChangeLog updated (9.76 KB, patch) 2013-10-15 14:45 PDT, Alexey Proskuryakov	ggaren: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (12.42 KB, patch) 2013-10-15 15:08 PDT, Alexey Proskuryakov	commit-queue: commit-queue-	Details Formatted Diff Diff
you not trust me? (12.42 KB, patch) 2013-10-15 20:49 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2013-10-15 14:44:36 PDT

Created attachment 214301 [details] proposed patch Alternatively, we could use an auto variable to hold the context, and make it work with any classes that have a context() method (as long as the context is registered as an opaque root). Not sure if that's desirable - there is no JS concept of "context", so tying it too deeply into generated code may be misleading. We already have bare "GenerateIsReachable" for those who prefer a universal mechanism.

Alexey Proskuryakov

Comment 2 2013-10-15 14:45:23 PDT

Created attachment 214302 [details] with ChangeLog updated

Mark Hahnenberg

Comment 3 2013-10-15 14:46:08 PDT

(In reply to comment #2) > Created an attachment (id=214302) [details] > with ChangeLog updated Hmm, I think something went wrong and the patch was uploaded as plaintext.

EFL EWS Bot

Comment 4 2013-10-15 14:51:07 PDT

Comment on attachment 214302 [details] with ChangeLog updated Attachment 214302 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/4109067

EFL EWS Bot

Comment 5 2013-10-15 14:54:41 PDT

Comment on attachment 214302 [details] with ChangeLog updated Attachment 214302 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/4103046

Geoffrey Garen

Comment 6 2013-10-15 15:01:02 PDT

Comment on attachment 214302 [details] with ChangeLog updated r=me

Alexey Proskuryakov

Comment 7 2013-10-15 15:08:45 PDT

Created attachment 214307 [details] patch for landing Builds were failing because I overlooked one of IDL files that used the old name (it should have been in Xcode project, but wasn't). Fixed that, and added the file to the project.

WebKit Commit Bot

Comment 8 2013-10-15 20:20:28 PDT

Comment on attachment 214307 [details] patch for landing Rejecting attachment 214307 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 214307, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Geoff Garen found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/4111121

Alexey Proskuryakov

Comment 9 2013-10-15 20:45:47 PDT

Comment on attachment 214307 [details] patch for landing How about this?

WebKit Commit Bot

Comment 10 2013-10-15 20:47:27 PDT

Alexey Proskuryakov

Comment 11 2013-10-15 20:49:47 PDT

Created attachment 214338 [details] you not trust me?

WebKit Commit Bot

Comment 12 2013-10-15 21:20:04 PDT

Comment on attachment 214338 [details] you not trust me? Clearing flags on attachment: 214338 Committed r157486: <http://trac.webkit.org/changeset/157486>

WebKit Commit Bot

Comment 13 2013-10-15 21:20:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.