Bug 122827

Summary:

FileIconLoader should not be ref-counted.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Forms

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description Andreas Kling 2013-10-15 05:15:58 PDT

Yeah.

Comment 1 Andreas Kling 2013-10-15 05:20:46 PDT

Created attachment 214249 [details]
Patch

Comment 2 Antti Koivisto 2013-10-15 05:39:50 PDT

Comment on attachment 214249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214249&action=review

> Source/WebCore/html/FileInputType.cpp:349
> +    m_fileIconLoader = std::unique_ptr<FileIconLoader>(new FileIconLoader(*this));

make_unique?

Comment 3 Andreas Kling 2013-10-15 06:00:54 PDT

Committed r157449: <http://trac.webkit.org/changeset/157449>