Bug 122808

Summary: didNotifySubtreeInsertions shouldn't be on Node since it's only implemented by HTMLFrameElementBase
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ahmad.saleem792, andersca, ap, benjamin, bfulgham, kling, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Work in progress none

Ryosuke Niwa
Reported 2013-10-14 20:34:41 PDT
The only class that implements didNotifySubtreeInsertions is Node and HTMLFrameElementBase. We shouldn't even have this function on Node. Simply check whether a given node is a HTMLFrameElementBase or not when we're constructing m_postInsertionNotificationTargets.
Attachments
Work in progress (4.17 KB, patch)
2013-10-14 21:05 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-10-14 20:34:53 PDT
This change was inspired by https://chromium.googlesource.com/chromium/blink/+/390c8633df7ead11d6440788b5b269126f171c37
Radar WebKit Bug Importer
Comment 2 2013-10-14 20:45:12 PDT
<rdar://problem/15228077>
Ryosuke Niwa
Comment 3 2013-10-14 20:53:41 PDT
Nm... this code is already optimized by having insertedInto return InsertionNotificationRequest. I guess we're not paying any extra cost here.
Ryosuke Niwa
Comment 4 2013-10-14 21:05:34 PDT
Created attachment 214229 [details] Work in progress
Ahmad Saleem
Comment 5 2022-08-19 23:49:18 PDT
rniwa@webkit.org - Is something needed now or we can mark this as "RESOLVED WONTFIX"? Thanks!
Ryosuke Niwa
Comment 6 2022-08-20 00:03:24 PDT
This is won't fix at this point.
Note You need to log in before you can comment on or make changes to this bug.